search

populationgenomics / metamist

Sample level metadata system
MIT License
1 stars 1 forks source link

Handle multiple participant external_ids in create_test_subset.py #825

Closed jmarshall closed 3 weeks ago

jmarshall commented 3 weeks ago

Fix oversight in PR #659's late changes to _create_testsubset.py: transfer_participants() also needs adjustment as Participant and ParticipantUpsert now have an external_ids field instead of an external_id field. We future-proof the two maps being built by adding all external ids, even though at present only the primary one is returned by the GraphQL queries.

In future we will represent the extra external ids in GraphQLParticipant too and revisit the initialisation of transfer_participant's external_ids field.

Context: https://centrepopgen.slack.com/archives/C020PDNH3N0/p1718340238722549?thread_ts=1718317460.582949&cid=C020PDNH3N0

codecov-commenter commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.04%. Comparing base (71dddbe) to head (3a51024).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #825 +/- ## ======================================= Coverage 79.04% 79.04% ======================================= Files 161 161 Lines 13607 13607 ======================================= Hits 10755 10755 Misses 2852 2852 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.