search

populationgenomics / metamist

Sample level metadata system
MIT License
1 stars 1 forks source link

Get_cram_paths external IDs fix #828

Closed EddieLF closed 3 weeks ago

EddieLF commented 3 weeks ago

A quick fix for the get_sample_cram_path_map_for_seqr Analysis table function to allow it to work with the recent external ID changes. Now joins to the participant_external_id table to get the external ID.

EddieLF commented 3 weeks ago

Thanks for the help @jmarshall, appreciate your input and the inclusion of a basic test case

jmarshall commented 3 weeks ago

Thanks for finding the problem…

If that test case had been there previously, this wouldn't have been missed out in the multiple-ext-ids PR because even this basic test would have failed. Turns out test coverage is a good thing!