search

populationgenomics / metamist

Sample level metadata system
MIT License
1 stars 1 forks source link

FIx lost sample aggregation logic #838

Closed nevoodoo closed 2 weeks ago

nevoodoo commented 2 weeks ago

Description

Based off the feedback received, our calculation for how a sample is treated as lost was not accurate. This patches that logic, updates the UI views accordingly and amends the relevant tests.

codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.15%. Comparing base (846c6b8) to head (06d44aa).

Files Patch % Lines
db/python/layers/ourdna/dashboard.py 85.71% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #838 +/- ## ========================================== - Coverage 79.17% 79.15% -0.03% ========================================== Files 161 161 Lines 13618 13622 +4 ========================================== Hits 10782 10782 - Misses 2836 2840 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.