search

populationgenomics / metamist

Sample level metadata system
MIT License
1 stars 1 forks source link

Fix project selector usage + fail tests on tsc build failure #847

Closed illusional closed 1 week ago

illusional commented 1 week ago

Hey @milo-hyben, I was poking around why the error didn't get flagged in tests, I've made some configuration changes to bubble these up during tests.

Do you mind fixing the billing errors, just commit straight to this branch:

     2  src/pages/billing/BillingCostByCategory.tsx:181
     2  src/pages/billing/BillingCostByMonth.tsx:122
     7  src/pages/billing/BillingCostByTime.tsx:105
    18  src/pages/billing/BillingInvoiceMonthCost.tsx:67
     1  src/pages/billing/components/CostByTimeBarChart.tsx:32
     3  src/shared/components/Graphs/BarChart.tsx:80
    20  src/shared/components/Graphs/DonutChart.tsx:94
    34  src/shared/components/Graphs/HorizontalStackedBarChart.tsx:81
     8  src/shared/components/Graphs/StackedAreaByDateChart.tsx:127
    31  src/shared/components/Graphs/StackedBarChart.tsx:164
     2  src/shared/components/ourdna/BarChart.tsx:42
     6  src/shared/components/ourdna/OurDonutChart.tsx:59
     1  src/shared/components/ourdna/StatTile.tsx:25
codecov-commenter commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.79%. Comparing base (7ef8905) to head (2e5ce57). Report is 1 commits behind head on dev.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #847 +/- ## ======================================= Coverage 79.79% 79.79% ======================================= Files 168 168 Lines 14140 14140 ======================================= Hits 11283 11283 Misses 2857 2857 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

milo-hyben commented 1 week ago

I went through all those tsc issues and fixed some of them. For those more challenging I've opted for // @ts-ignore It might take a bit more time to get them fixed. And I want to be sure the reports are still working for tomorrow presentation. npm run build works locally, only warning regarding the minification size is shown. Wonder if that is making the unit test failing.

milo-hyben commented 1 week ago

So that vite/minification size warning is not the corporate for those failing tests, not sure what is going on there.

illusional commented 1 week ago

Thanks @milo-hyben, I randomly added an exit, but I've removed that now and it's passing