Open MattWellie opened 1 month ago
I'm just trying to think of a simple way to make codecov happy, presumably by testing that the parser is working correctly (?)
Yeah, there's a couple of ways to solve that. I'll have a tinker this morning!
Attention: Patch coverage is 98.38710%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 80.83%. Comparing base (
e3a7f39
) to head (c6272c4
). Report is 5 commits behind head on dev.
Files | Patch % | Lines |
---|---|---|
scripts/create_custom_cohort.py | 90.90% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Interface changes
Needed
create_cohort_from_criteria
it's ignored. This PR has not resolved thatQOL
type=str, nargs='*'
to anargs='*', default=[]
- the type here was misleading as we want a list?required=False, type=list[str]
tonargs='*', default=[]
type
doesn't work with nested types (afaik, the passed type is used as a callable), solist[str]
is justlist
type
also casts values to the given type, so--sg_platform illumina
becomes['i', 'l', 'l', 'u', 'm', 'i', 'n', 'a']
, instead of['illumina']
(the result oflist(input)
instead of[input]
Strict Checking
choices
- could bin this off, or query metamist for the available choices at runtime.Challenge:
Current Result: (I couldn't find any way to use multiple CPG IDs, so just using a list of one in this toy example)
New Result: