search

populationgenomics / metamist

Sample level metadata system
MIT License
1 stars 1 forks source link

Add copying of application code back into deploy dockerfile #979

Closed dancoates closed 1 month ago

dancoates commented 1 month ago

This was accidentally removed in PR #957, causing the container to not start correctly due to missing application code

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.56%. Comparing base (4305682) to head (7a13c7a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #979 +/- ## ======================================= Coverage 81.56% 81.56% ======================================= Files 184 184 Lines 15957 15957 ======================================= Hits 13016 13016 Misses 2941 2941 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jmarshall commented 1 month ago

Is it that this was inadvertently / incorrectly removed in PR #957?

(It'd be great to have that context — and what went wrong, if anything — in the commit message or as a comment here.)

Also they were previously in alphabetical order, so it'd help diffing a tiny bit if this put them back identically.

dancoates commented 1 month ago

Thanks @jmarshall good points, I've added a reference to the PR in the commit, and fixed the ordering to match what it was previously for better diff/blame.