porres / pd-else

ELSE - EL Locus Solus' Externals for Pure Data
Do What The F*ck You Want To Public License
296 stars 35 forks source link

scope~ #1358

Closed porres closed 8 months ago

porres commented 2 years ago

REMOVE PROPETIES PREVIEW?

@timothyschoen would you be able to help me with that?

Also, would you ever help me out figuring out how to deal with the crazy tcl/tk code? :)

timothyschoen commented 2 years ago

I don't have much time at the moment, I really need to finish the next version of PlugData, so it has the new ELSE version. Also messing with tcl/tk code is very time-consuming for me because I have no idea what I'm doing.

I might find some time before the next version of ELSE comes out though!

porres commented 2 years ago

@flschiavoni uma coisa simples seria essa alteração nas propriedades do oscope~ me ajudaria em momento oportuno?

porres commented 2 years ago

ping @timothyschoen

timothyschoen commented 2 years ago

Oh these are only a few changes to the dialog. I think I can handle this!

I think I mentioned this somewhere, I'm also hoping to create an "auto" mode for [oscope~], where it will automatically resize the buffer and range to fit a single cycle of the input signal. This will require some basic pitch-detection algorithm. We can probably steal it from aubio, or from the [sigmund~] object.

porres commented 2 years ago

that would be awesome to have in oscope~ so sure :) let's do it :)

what about zero crossings, too poor?

timothyschoen commented 2 years ago

Could be okay, but it will start messing up when your wave has phase differences in its harmonics.

Simply finding the peak of an fft might be better, it would introduce a slight latency.

timothyschoen commented 2 years ago
Screenshot 2022-11-04 at 16 08 25

Is this good? Maybe some more padding around the preview?

porres commented 2 years ago

I'd prefer it would be on the right :)

porres commented 2 years ago

there was an external based on aubio once... I wouldn't mind including a new one into ELSE :)

porres commented 2 years ago

https://puredata.info/downloads/aubio/?searchterm=aubio

timothyschoen commented 2 years ago

Aubio does have fantastic pitch and onset detection! The ability to switch algorithms to something that works for your input source is also great.

Having a good onset detection object is something that some people have requested for PlugData, it's very useful in a DAW (for building all kinds of effects that get triggered by an onset). It would be nice in Pd-vanilla as well, of course.

porres commented 2 years ago

Vanilla's onset detector is bonk~ right? have you tried it?

timothyschoen commented 2 years ago

I hadn't tried it yet, I guess the person who requested this was either unaware of it, or dissatisfied with it?

timothyschoen commented 2 years ago

Should I get rid of drawstyle in the whole object?

porres commented 2 years ago

I havent tried bonk~ either :) it's been on my list forever, I need to include it in my tutorial :) one way or another I bet we can have nice alternative externals that are easier to use.

I could get rid of drawstyle in the object myself but you can go ahead :)

porres commented 2 years ago

you know what @timothyschoen the whole preview is actually pointless as the object itself is updated when you set colors. I say we just remove it