search

porres / pd-else

ELSE - EL Locus Solus' Externals for Pure Data
Do What The F*ck You Want To Public License
287 stars 36 forks source link

fixes for grid and min rate #2063

Closed ben-wes closed 5 months ago

ben-wes commented 5 months ago

min rate was not restricted - went crazy with delay of 0. grid wasn't properly clipped for clip:1

porres commented 5 months ago

issues I reported are exactly the same

Screen Shot 2024-03-17 at 11 44 34

there is this error when adjusting dimensions and the plot does not adjust to the dimensions anymore and get clipped

porres commented 5 months ago

the rotation seems better now, rotatex rotatres horizontally, but counter clock wise if look from above and that doesn't seem right at all to me, cause I am dragging to the right I want to see it rotate in the same direction. maybe y is reversed too...

rotate message still has x/y reversed...

but I also get "scope3d~: no method for 'float'" when adjusting it

still seems CPU heavy as GUI freezes

porres commented 5 months ago

just fixed 'rotate'

ben-wes commented 5 months ago

can you push the fix?

i'm trying to find out where that error message comes from. when i test dim here with new scope, it's all good. totally weird ...

porres commented 5 months ago

my fix fucked with rotatex, so I don't know what is going on and reverted back, you fix this :)

ben-wes commented 5 months ago

FFUUUUUCCCKKK ... i found the problem and it's quite funny: scope currently defaults to a receiver named empty and obviously, your knobs are sending to empty by default. i fixed it for scope3d~ now and there's no receiver set at all. but i think, you should also fix your knobs to not send any messages by default. PR incoming ...

ben-wes commented 5 months ago

ok, about the rotation: which axis should i invert now? :)

porres commented 5 months ago

i'm trying to find out where that error message comes from. when i test dim here with new scope, it's all good. totally weird ...

really weird you can't reproduce this... since you included 'flames' I guess, this started happening

performance is not doable here with 50ms refresh rate, still bad, it got worse with clipping I guess

It seems things were really ok and better before flames and clip :)

porres commented 5 months ago

ok, about the rotation: which axis should i invert now? :)

rotate gets y and x, should be x and y

ben-wes commented 5 months ago

It seems things were really ok and better before flames and clip :)

yeah ... it included many changes. but flames shouldn't really be the problem since the performance is dependant on perform and paint routines. i changed quite some stuff there. but with the last optimizations, it's faster for me. which patch are you testing with? the help itself?

ben-wes commented 5 months ago

can we make an issue for the open scope3d~ things? or use the other one? so that we don't discuss in the PRs?

porres commented 5 months ago

sure, let's go back to the issue, or even reboot it