search

postgrespro / pgsphere

PgSphere provides spherical data types, functions, operators, and indexing for PostgreSQL.
https://pgsphere.org
BSD 3-Clause "New" or "Revised" License
16 stars 14 forks source link

`pg_sphere_version()` reports version that is different from extension version. #10

Closed andy-slac closed 1 year ago

andy-slac commented 1 year ago

With just installed pg_shere from current master, and we observe difference in reported version numbers between pg_sphere_version() and extension version:

=> select pg_sphere_version();
 pg_sphere_version
-------------------
 1.1.5

=> SELECT extversion from pg_catalog.pg_extension where extname = 'pg_sphere';
 extversion
------------
 1.2.0

Aren't they supposed to be the same?

vitcpp commented 1 year ago

PR #23 is prepared. The idea is to propagate PGSPHERE_VERSION from Makefile into the code. It allows to have the single place where pg sphere version is set. One more place is the .control file where default_version should be changed as well. There is an idea to add some rule into Makefile to replace default_version with the latest one. Another way is to keep it unchanged. The version mismatch probably will fail the tests if to forget to change the version in .control file (some testing is needed).

esabol commented 1 year ago

PR #23 was merged, so I think this issue can be closed.