search

postgrespro / pgsphere

PgSphere provides spherical data types, functions, operators, and indexing for PostgreSQL.
https://pgsphere.org
BSD 3-Clause "New" or "Revised" License
16 stars 15 forks source link

fix Makefile dist target #114

Closed pdowler closed 6 months ago

pdowler commented 7 months ago

the sparse.c and sscan.c files are now committed in src dir

I use the dist target to create tarballs as part of building rpm packages.

vitcpp commented 6 months ago

@pdowler There is intention to remove these files from the src directory and auto-generate it. Can such possible change break your rule?

pdowler commented 6 months ago

When I added that rule back in 1.1.x those files were generated in the base dir and it was the quick and dirty way to make a src tarball... wasn't the right choice back then. Now, it looks like the C files are in src and committed to git so that is no longer needed.

If there is a change in future to not have those generated C files committed, then next time around I'll fix the rpm build setup instead so it can generate them correctly.

I don't know the pros and cons of those files being committed to git... probably wouldn't have been my choice (minimalist)., but I don't intend to change that.