search

postgrespro / pgsphere

PgSphere provides spherical data types, functions, operators, and indexing for PostgreSQL.
https://pgsphere.org
BSD 3-Clause "New" or "Revised" License
16 stars 15 forks source link

Alter spoint op family to add missed operator 17 (<->) #121

Closed vitcpp closed 2 months ago

vitcpp commented 2 months ago

The upgrade script misses the altering of spoint operator family to add operator 17. It is required for k-NN search.

df7cb commented 2 months ago

Fwiw I think you shouldn't touch --1.5.0.sql given that has been released, even when it was just a pre-release. (I would suggest labeling pre-releases as beta or RC, then the question might not be as relevant.)

vitcpp commented 2 months ago

@df7cb That was my unspoken question - whether to move the tag or create 1.5.1. Looking at our README I think to create 1.5.1. I will update the patch. It seems, the next release will be 1.5.1. Zeroes are unhappy :) Thank you.

esabol commented 2 months ago

Pre-releases are not releases. I'm ok with this being part of 1.5.0, personally.

df7cb commented 2 months ago

But git tags are tags and should not be moved if people might already have seen them. I have not yet built Debian packages from that tag yet, but if I had and you moved it around afterwards, I would be quite upset.

Also, if the pre-release is supposed to serve any purpose, it is for people to actually build and test it. Please don't confuse people by making another release with the same name.

vitcpp commented 2 months ago

@esabol It seems, it is not easy to move the tag, the branch is protected. Furthermore, @df7cb has reasonable arguments against it. I will create 1.5.1 this time. Later, I will assign pre-releases more carefully.

esabol commented 2 months ago

Well, Ok, but then there's no point in having pre-releases at all, and I suggest we not have them in the future.

df7cb commented 2 months ago

Just name them 1.6rc1 or the like and everything is fine.

vitcpp commented 2 months ago

@esabol Are you ok with these changes?