search

postgrespro / pgsphere

PgSphere provides spherical data types, functions, operators, and indexing for PostgreSQL.
https://pgsphere.org
BSD 3-Clause "New" or "Revised" License
16 stars 15 forks source link

Fix build under mingw64 #123

Closed vitcpp closed 1 month ago

vitcpp commented 2 months ago

@robe2 This patch should fix your issue. Could you please check the compilation of this patch on your side? Thank you in advance.

esabol commented 2 months ago

These changes are more extensive than I was expecting. I'm not sure they should be included in 1.5.1.

vitcpp commented 2 months ago

@esabol Actually, my changes are in sparse.y and in sscan.l. Other files (h/c) are auto generated from those two ones.

esabol commented 2 months ago

@vitcpp wrote:

Actually, my changes are in sparse.y and in sscan.l. Other files (h/c) are auto generated from those two ones.

I realize that. It's still more changes than I'm comfortable with personally, but whatever. If you want to include it in 1.5.1, I'm fine with it.

vitcpp commented 2 months ago

@esabol Well, lets postpone this fix until the next release. Honestly, I'm not comfortable with these changes as well. Tomorrow I will create a new release.

vitcpp commented 1 month ago

I decided to propose a less invasive fix. There are two commits: first commit just regenerates parser files, second commit does the fix of token names. I used two commits to make differences more predictable. I used GNU Bison 3.4.2 to generate parser files.