search

postgrespro / pgsphere

PgSphere provides spherical data types, functions, operators, and indexing for PostgreSQL.
https://pgsphere.org
BSD 3-Clause "New" or "Revised" License
16 stars 14 forks source link

strans is broken #17

Closed vitcpp closed 11 months ago

vitcpp commented 1 year ago

There is an issue with strans that was reported in another repo. Check and fix it in our repo.

https://github.com/akorotkov/pgsphere/issues/11

esabol commented 1 year ago

Could be related to this precision issue?

https://github.com/akorotkov/pgsphere/issues/13

I see a lot of floats in the code. Would changing everything to double precision be a good idea?

vitcpp commented 1 year ago

I think double precision should be ok. I haven't looked at this problem yet. I think it may be related to the custom epsilon that is choosen as 1E-9 in pgsphere (pg_sphere.h:48). May be it is the source of the problem. May be we should make EPSILON smaller.

dura0ok commented 11 months ago

Issue can be closed, probably, @vitcpp

vitcpp commented 11 months ago

@stepan-neretin7 Thank you for your contribution. Closing the issue.