postgrespro / pgsphere

PgSphere provides spherical data types, functions, operators, and indexing for PostgreSQL.
https://pgsphere.org
BSD 3-Clause "New" or "Revised" License
16 stars 14 forks source link

Improve versioning of pgsphere #20

Closed vitcpp closed 1 year ago

vitcpp commented 1 year ago

Introduce releases

vitcpp commented 1 year ago

Dear All, I would like to agree on versioning of pgsphere:

What I'm concerned, now we increment only the third number (patch number) for those changes that include API changes. I guess we should increment minor number in this case. But if we decide to increment minor number on each API small change this number may become too big.

One more question - should we increment minor or patch number each time when merging a new PR or introduce release plan?

Another issue is an optional compilation of some parts like healpix. I do not exclude that some new optional compilation will appear in the near future. I think it should be the user responsibility how to compile. The version number should not reflect how pgsphere is compiled. I see the only issue - upgrade scripts. I guess we may implement some query function that returns the list of compiled features. It may help upgrade script to decide what to do.

I appreciate any comments, thank you!

vitcpp commented 1 year ago

It seems this issue is a duplicate of #9. Closing it.

esabol commented 1 year ago

It seems this issue is a duplicate of #9. Closing it.

I didn't see these as duplicates, but I'm ok with combining them. I thought this issue was for releasing new versions at https://github.com/postgrespro/pgsphere/releases. I thought issue #9 was going back in the commit history of repository and tagging old releases.

vitcpp commented 1 year ago

Well, I thought that it is a single complex problem with versions. Furthermore, there were some talks about producing release artifacts. It is why I decided to have the single issue for discussion. Anyway, I have no objections to reopen this Issue.

esabol commented 1 year ago

Well, I thought that it is a single complex problem with versions.

Yes, I agree with that.