postgrespro / pgsphere

PgSphere provides spherical data types, functions, operators, and indexing for PostgreSQL.
https://pgsphere.org
BSD 3-Clause "New" or "Revised" License
16 stars 14 forks source link

[ISSUE-10] Implemented propagation of pg sphere version. #23

Closed vitcpp closed 1 year ago

vitcpp commented 1 year ago

Implemented propagation of pg sphere version from Makefile into the code. Fixed pg_sphere_version function.

vitcpp commented 1 year ago

It seems there are build problems on 11+ versions. The error is occured when compiling with clang. It seems PG_CFLAGS is not used with clang. Not sure, how clang compilation is performed. I see no clang rules. It is interesting that there is no clang compilation with 10 version. Investigating it.

vitcpp commented 1 year ago

The problem with clang was because of JIT compilation (--with-llwm option). Variables PG_CXXFLAGS, PG_CFLAGS are not propagated into clang compilation. Using PG_CPPFLAGS fixes the problem.

vitcpp commented 1 year ago

@esabol thank you for the review. I'm going to merge this PR because there are no objections.