Closed msdemlei closed 2 years ago
On Wed, Nov 10, 2021 at 12:57 PM msdemlei @.***> wrote:
Some pgsphere tests fail in Postgres 14 for reasons I've not investigated more closely yet; cf. https://pgdgbuild.dus.dg-i.net/view/Binaries-Beta/job/pgsphere-binaries-beta/lastFailedBuild/architecture=amd64,distribution=sid/console, search for regression.diffs.
Is someone already looking into v14 compatibility of pgsphere?
It certainly should be fixed !
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/postgrespro/pgsphere/issues/3, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQURYVDULBVQ4TG7GONA6DULI6XRANCNFSM5HXOMSZA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
-- Postgres Professional: http://www.postgrespro.com The Russian Postgres Company
The problem is caused by Tom Lane's commit 8597a48d01b which fix incorrect handling on infinity in FP* macros in geo_decls.h. At the same time it replaces macros with static functions after which trick with redefinition of EPSILON (because ph_sphere needs 1.0E-09 vs. 1.0E-06) doesn't work any more.
I do not have permissions to push in this repository, so I have created fork with my fixes: https://github.com/knizhnik/pg_sphere
I saw the code, checked it on pg14-compat branch and pushed.
Some pgsphere tests fail in Postgres 14 for reasons I've not investigated more closely yet; cf. https://pgdgbuild.dus.dg-i.net/view/Binaries-Beta/job/pgsphere-binaries-beta/lastFailedBuild/architecture=amd64,distribution=sid/console, search for regression.diffs.
Is someone already looking into v14 compatibility of pgsphere?