search

postgrespro / pgsphere

PgSphere provides spherical data types, functions, operators, and indexing for PostgreSQL.
https://pgsphere.org
BSD 3-Clause "New" or "Revised" License
16 stars 15 forks source link

[ISSUE #16] Implemented a function and tests to extract vertices from spoly by index #37

Closed dura0ok closed 11 months ago

dura0ok commented 11 months ago

@esabol @vitcpp please, review it.

dura0ok commented 11 months ago

What about this pull request? Is it approved? @esabol

esabol commented 11 months ago

What about this pull request? Is it approved? @esabol

It's perfect other than PR https://github.com/postgrespro/pgsphere/pull/38 also bumps the version to 1.3.0 and adds an upgrade script. So I recommended merging PR https://github.com/postgrespro/pgsphere/pull/38 first and then git rebase this PR on the new master. Or you could do it in the opposite order, if you prefer.

Thank you, @stepan-neretin7, for all your work!

dura0ok commented 11 months ago

Thank you also very much for your patient, detailed review of my code (I'm just learning and it's very valuable to me). Yes, I have added a version update here too and there will be no problems with rebase in any order. Therefore, @vitcpp can merge in any order It turns out that this pull request is also approved by @esabol?

esabol commented 11 months ago

@stepan-neretin7 : Now that PR #38 has been merged, I think this PR could use a git rebase since the changes to the Makefile are no longer needed and the changes to the upgrade script will likely conflict.

dura0ok commented 11 months ago

Can we merge it? @vitcpp