Add BRIN support for spoint and sbox?

postgrespro / pgsphere

PgSphere provides spherical data types, functions, operators, and indexing for PostgreSQL.

https://pgsphere.org

BSD 3-Clause "New" or "Revised" License

16 stars 15 forks source link

Add BRIN support for spoint and sbox? #52

Closed esabol closed 10 months ago

esabol commented 10 months ago

Would incorporating this PR be useful to anyone? It was fully working but never merged. It seems a waste to not retain this functionality, and it could be a real benefit when dealing with very large tables with millions of points.

See https://github.com/akorotkov/pgsphere/pull/8 and this comment.

gbroccolo commented 10 months ago

Hi, I see @vitcpp already opened a PR here (will leave comments there eventually). I'm happy to help if needed.

vitcpp commented 10 months ago

@gbroccolo Thank you for the patch! I preserved your authorship of the patch with some code adjustments. I believe, you don't mind if the patch will be applied in this repo. We also appreciate it if you will open some new PRs in this repo that seems to be the only alive repo of the pgSphere project.

gbroccolo commented 10 months ago

Hi @vitcpp fine. Will try to open new PRs, each one for each spherical geometry, any sooner. I will probably start with the circular type, as requested by @esabol.