search

postgrespro / pgsphere

PgSphere provides spherical data types, functions, operators, and indexing for PostgreSQL.
https://pgsphere.org
BSD 3-Clause "New" or "Revised" License
16 stars 15 forks source link

Fix diff in the test moc100 on PG16 #57

Closed vitcpp closed 10 months ago

esabol commented 10 months ago

I confused as to why this change is working on PG 10-15. I thought only the PG16 build broke and the test output was unaltered on PG 10-15.

vitcpp commented 10 months ago

@esabol expected/moc100_4.out is applied only in case of PG16:

https://www.postgresql.org/docs/current/regress-variant.html

Other "golden" files expected/moc100_*.out are applied for other versions of postgres. You can see that the beginning of each file contains some output that is specific for each version. It plays the role of a filter. For unsuitable versions, it will produce differences and the golden file will be skipped.

esabol commented 10 months ago

Oh, interesting!