Closed borodun closed 9 months ago
I also dream of a GitHub Actions pipeline which, on merges to the master branch, uploads the latest documentation to the GitHub Pages associated with this repository. Could you help with that? That's probably a separate pipeline though.
@borodun: Actually, I think "make test" should come before "make install"?
Also, I am curious as to why you chose fail-fast: false
?
@esabol, I moved make test
before make install
. About fail-fast: false
: I wanted to make the CI behavior the same as the current Travis pipeline, it will not cancel jobs if other jobs fail first. In my opinion, this will help to get more informative pipeline runs.
@esabol, regarding the pipeline for docs: that’s the plan. We need to organize access to GitHub Pages for this repository. This is a more administrative issue. We want to get this done as soon as possible.
The new GitHub Actions pipeline doesn't seem to be working in PR #65, unfortunately. Very weird error that I've not encountered before in my GitHub Actions.
@esabol, @borodun It seems the problem is in line 63 of build-and-check.yml: github.ref_name is 65/merge. It seems the / symbol should be replaced with some other acceptable symbol or another var should be used.
Changing the '/' to a '-' in $github_ref_name
can be done as shown here:
https://github.com/mbiagetti/github-action-poc/pull/2/files
But that method seems very convoluted and annoying. Would this method work?
We can use something like https://github.com/marketplace/actions/github-slug-action to create slugged versions of variables. We can add:
- name: Inject slug/short variables
uses: rlespinasse/github-slug-action@v4
And change ${{ github.ref_name }}
to ${{ env.GITHUB_REF_SLUG_URL }}
I'll create PR
Use GitHub Actions for pgSphere pipeline. At this moment, builds with HEALPix are failing due to compilation warning, but https://github.com/postgrespro/pgsphere/pull/68 should fix this.