search

postgrespro / pgsphere

PgSphere provides spherical data types, functions, operators, and indexing for PostgreSQL.
https://pgsphere.org
BSD 3-Clause "New" or "Revised" License
16 stars 14 forks source link

Format the code with pgindent #72

Closed vitcpp closed 11 months ago

esabol commented 1 year ago

I don't really like pgindent's excessive whitespace, but I'm ok with it if this is something you want.

vitcpp commented 1 year ago

@esabol I would suggest to consider this PR as a proposal, not a solution to be applied unconditionally. I agree with you about excessive indentation and I'm not a fan pgindent. Furthermore, the formatting of some mathematical expressions should be untouched. But I do not know another solution that may help us with the indentation. We may use pgindent as a code formatting verification tool. We will be able to automate this process. Anyway, I'm ok if we decide to reject this PR and do not use pgindent.

esabol commented 1 year ago

I think it’s up to you. I don’t have a strong opinion on it.

vitcpp commented 1 year ago

I think it would be better to limit the pgindent functionality somehow. I would propose to fix only identations at the beginnings of the strings, and function signatures. The formatting of formulae should be untouched.

vitcpp commented 11 months ago

Rejected, because it is outdated.