search

powsybl / powsybl-dev-tools

2 stars 1 forks source link

Viewer for powsybl-network-area-diagram #40

Closed louislhotte closed 2 years ago

louislhotte commented 2 years ago

Please check if the PR fulfills these requirements

Does this PR already have an issue describing the problem ? Fixes #32

sonarcloud[bot] commented 2 years ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 3 Security Hotspots
Code Smell B 184 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

sonarcloud[bot] commented 2 years ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 4 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 9 Security Hotspots
Code Smell B 174 Code Smells

0.0% 0.0% Coverage
3.8% 3.8% Duplication

louislhotte commented 2 years ago

The pom.xml should not be merged into main (except for the ucte support that was added by flo-dup).

flo-dup commented 2 years ago

The pom.xml should not be merged into main (except for the ucte support that was added by flo-dup).

What do you mean? I suppose you mean from main into this PR, as you reverted the changes of the merge commit?

But why shouldn't we applied the changes from main? the goal of this tool is for developers to test the latest changes of the powsybl-network-area-diagram, hence the latest snapshot version: 0.5.0-SNAPSHOT.

louislhotte commented 2 years ago

The pom.xml should not be merged into main (except for the ucte support that was added by flo-dup).

What do you mean? I suppose you mean from main into this PR, as you reverted the changes of the merge commit?

But why shouldn't we applied the changes from main? the goal of this tool is for developers to test the latest changes of the powsybl-network-area-diagram, hence the latest snapshot version: 0.5.0-SNAPSHOT.

Sorry, I didn't formulate it well. There is still one bugfix I would like to address so I will keep working on the oldest version until everything works perfectly and only then will I transition to the lastest version. Therefore, merging into main should not be done yet as the pom.xml is still the old one (that I still commited in case someone wants to test where the viewer is at).

flo-dup commented 2 years ago

Too many changes needed to clean the code, replaced by #54