powsybl / powsybl-dev-tools

2 stars 1 forks source link

upgrade diagram viewer to powsybl 2023.3.0 #81

Closed zamarrenolm closed 1 year ago

zamarrenolm commented 1 year ago

Please check if the PR fulfills these requirements

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

Update dependencies.

What is the current behavior?

What is the new behavior (if this is a feature change)? Minimal refactoring to adapt to the new API in PowSyBl diagrams.

Does this PR introduce a breaking change or deprecate an API?

Other information:

So-Fras commented 1 year ago

The current state of the code is not completly satisfactory.

I suggest to let it this way until next release of powsybl-diagram (V4.1.0). That release is going to correct a bug in the new single-line diagram API so that VoltageLevelLayoutFactory customization will be possible again.

That correction should be reflected in powsybl-dev-tools. The VoltageLevelLayoutFactoryCreator should be built inside a VoltageLevelLayoutFactoryCreatorBean:

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication