search

powsybl / powsybl-dev-tools

2 stars 1 forks source link

Issue 88 - Add IdentifiableType filter #93

Closed tadam50 closed 6 months ago

tadam50 commented 7 months ago

Please check if the PR fulfills these requirements

Does this PR already have an issue describing the problem? 'Fixes #88'

tadam50 commented 7 months ago

I suggest to use IdentifiableType enumearation as filter on connectable components. If we use this enumeraration, we could use NETWORK value to keep all components (no filtering use case). But i've no use case in mind to use SUBSTATION and VOLTAGE_LEVEL items. Are these items need to be removed from list in filtering widget ?

See following animation for example : issue-88

flo-dup commented 7 months ago

Juste realized that one thing which is not covered by current approach is the phase-shift transformers. That would probably lead to another custom enum, where each value would provide a Function<Network, List<VoltageLevel>>. That would also allow us to remove the enum values which don't make so much sense.

Do you feel like doing it in this PR? or rather in another PR?

So-Fras commented 6 months ago

Adding the phase-shift transformers to the list is very useful but I think that (and the refactoring that ensues) should be done in another PR.

sonarcloud[bot] commented 6 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud