search

ppizarror / PyDetex

An application that transforms LaTeX code to plain text
https://pydetex.readthedocs.io/
MIT License
38 stars 5 forks source link

Dev emph #30

Closed xionghuichen closed 2 years ago

xionghuichen commented 2 years ago

Hi, I add support on \emph, which has the same process flow as \textit.

codecov[bot] commented 2 years ago

Codecov Report

Merging #30 (536a4f9) into master (970d74f) will increase coverage by 0.00%. The diff coverage is 100.00%.

:exclamation: Current head 536a4f9 differs from pull request most recent head 3e00a2d. Consider uploading reports for the commit 3e00a2d to get more accurate results

@@           Coverage Diff           @@
##           master      #30   +/-   ##
=======================================
  Coverage   98.42%   98.42%           
=======================================
  Files          10       10           
  Lines        1716     1717    +1     
=======================================
+ Hits         1689     1690    +1     
  Misses         27       27
Impacted Files Coverage Δ
pydetex/parsers.py 99.86% <ø> (ø)
pydetex/_utils_tex.py 99.27% <100.00%> (+<0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 970d74f...3e00a2d. Read the comment docs.

ppizarror commented 2 years ago

Thanks!

ppizarror commented 2 years ago

I've removed emph file as it is the same as textit. Also added a simple test. @xionghuichen Let me know if you want to add more features. If not I'll release this new version 0.9.6.

xionghuichen commented 2 years ago

cool. I copied u_textit.txt to u_emph.txt for better readability of the related code. But I think both the solutions are ok :)

ppizarror commented 2 years ago

@xionghuichen pypi version updated to 0.9.6. Thanks :)