praydog / REFramework

Scripting platform, modding framework and VR support for all RE Engine games
https://cursey.github.io/reframework-book/
MIT License
2.83k stars 350 forks source link

[MHR] hook conflicts #500

Open DerKleineLi opened 2 years ago

DerKleineLi commented 2 years ago

When using the following mods togther:

The skip intro logos does not work, it seems that hooking the following functions at initialization caused this issue:

snow.data.DataShortcut.getCommandHud(snow.data.DataDef.PlWeaponActionId)
snow.data.DataShortcut.getName(snow.data.DataDef.PlWeaponActionId)
snow.data.SwitchActionSystem.getEquippedActionMySetDataList(snow.data.weapon.WeaponTypes, snow.data.SwitchActionEquipType)

This might be a bug of reframework, since the two mods hook different functions and there should not be a conflict.

DerKleineLi commented 2 years ago

In addition, using Remove Monster Kill-Cam Plus Stylish SlowMo Finishers (ver 2.6) togther with skip intro logos (ver 1.2) disables the functionality of the former.