prebid / line-item-manager

Prebid Line Item Management Tool
Other
30 stars 17 forks source link

Support for same ad size being served several times on the same page #42

Open dshore opened 3 years ago

dshore commented 3 years ago

Description

I would like to be able to do orders by size where each line item contains e.g. only 1 size. In this example I would like to have many creatives but all are for one size only.

dshore commented 3 years ago

Proposed Enhancement

Support configurations when "size_override" is False that allows user to specify the number of copies of the creative desired, eg:

creative: # at least one of the following types is required {video, banner}
  name: "Prebid {{ bidder_name }}-{{ media_type }}"
  banner:
    # safe_frame: False # optional: defaults to True
    size_override: False # optional: defaults to True with a 1x1 creative
    copies: 5 # new field
    sizes: # list
      - height: 480
        width: 640
    snippet: |
      <script src = "https://..."></script>
        <script>
          ...
        </script>
Zer0Divis0r commented 3 years ago

@dshore , can you please clarify: "size_override: False" and "copies: 5" does exactly what? If I specify 10 sizes, and I have 450 line items, how many LICA objets will it create? Same question is for "size_override: True", 10 sizes and 450 line items creates 4500 LICA objects, as far as I see in the other issue discussing the size_override feature it was suppsed to create to more then 5 LICAs, but I see that it creates a LICA per line item per size's creative.

dshore commented 3 years ago

This option has copies in sizes array - agreed by committee that this is preferable:


creative: # at least one of the following types is required {video, banner}
  name: "Prebid {{ bidder_name }}-{{ media_type }}"
  banner:
    # safe_frame: False # optional: defaults to True
    size_override: False # optional: defaults to True with a 1x1 creative
    sizes: # list
      - height: 480
        width: 640
        copies: 5
     - height: 300
       width: 250
       copies: 3
    snippet: |
      <script src = "https://..."></script>
        <script>
          ...
        </script>
shuaibjewon-qz commented 1 year ago

Hi @dshore

Reviving this. I recently implemented duplicating creatives for banner. Made a draft PR with my changes. Happy to make this more granular (specify number of copies by size) and get this merged if this feature is still desired.