predict-idlab / plotly-resampler

Visualize large time series data with plotly.py

https://predict-idlab.github.io/plotly-resampler/latest

MIT License

1.03k stars 68 forks source link

Decouple non-modular if-else statement from the AggregatorParser #188

Open jonasvdd opened 1 year ago

jonasvdd commented 1 year ago

154 added a new hierarchy-based `aggregator` class structure, which requires different down sample implementations

Currently, this is resolved by an if-else statement in the PlotlyAggregatorParser its aggregate method, which is not that clean / modular.

Consider splitting the downsample and datapointselector into two different fields
that way you can avoid all of this switching and have well-defined types. TODO:
[ ] add link to code location where this switching occurs.