predict-idlab / plotly-resampler

Visualize large time series data with plotly.py
https://predict-idlab.github.io/plotly-resampler/latest
MIT License
1k stars 67 forks source link

🧹 fix typo in docstring + remove LTTB from MinMaxLTTB + remove interleave_gaps #201

Closed jonasvdd closed 1 year ago

codecov-commenter commented 1 year ago

Codecov Report

Merging #201 (a43fa54) into main (614c9de) will decrease coverage by 0.33%. The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
- Coverage   97.44%   97.11%   -0.33%     
==========================================
  Files          13       13              
  Lines         979      972       -7     
==========================================
- Hits          954      944      -10     
- Misses         25       28       +3     
Impacted Files Coverage Δ
...tly_resampler/aggregation/aggregation_interface.py 94.91% <ø> (-0.09%) :arrow_down:
...tly_resampler/figure_resampler/figure_resampler.py 89.16% <ø> (ø)
...ler/figure_resampler/figure_resampler_interface.py 100.00% <ø> (ø)
plotly_resampler/aggregation/aggregators.py 100.00% <100.00%> (ø)
plotly_resampler/aggregation/gap_handlers.py 96.00% <100.00%> (-4.00%) :arrow_down:
..._resampler/aggregation/plotly_aggregator_parser.py 94.44% <100.00%> (-2.19%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

jvdd commented 1 year ago

still 1 job that failed over the nans...

jonasvdd commented 1 year ago

Not consistently, I guess? @jvdd

jonasvdd commented 1 year ago

@jvdd, Do I handle here the Interleave gaps issue as well?

jvdd commented 1 year ago

@jvdd, Do I handle here the Interleave gaps issue as well?

@jonasvdd sure!

jonasvdd commented 1 year ago

Okay @jvdd, decided to open a seperate PR which will be merged into this one w.r.t. the interleave gaps, see #204

jonasvdd commented 1 year ago

I think this PR can be merged as well @jvdd?