predict-idlab / plotly-resampler

Visualize large time series data with plotly.py
https://predict-idlab.github.io/plotly-resampler/latest
MIT License
1k stars 67 forks source link

:eyes: comment out reset layout #228

Closed jvdd closed 1 year ago

jvdd commented 1 year ago

Fixes #223

codecov-commenter commented 1 year ago

Codecov Report

Merging #228 (78461a5) into main (c905478) will increase coverage by 0.04%. The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
+ Coverage   97.06%   97.11%   +0.04%     
==========================================
  Files          13       13              
  Lines         988     1005      +17     
==========================================
+ Hits          959      976      +17     
  Misses         29       29              
Impacted Files Coverage Δ
...ler/figure_resampler/figure_resampler_interface.py 99.74% <ø> (+<0.01%) :arrow_up:

... and 5 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

jvdd commented 1 year ago

@jonasvdd any reason why we had the reset layout (autorange & range) for x and y axes in the constructor?


If we have a legit reason to do this, we can toggle this behavior by adding a new constructor argument (e.g., reset_axes_range, which defaults to True)

jonasvdd commented 1 year ago

I'm fine with commenting this out!