predict-idlab / plotly-resampler

Visualize large time series data with plotly.py
https://predict-idlab.github.io/plotly-resampler/latest
MIT License
1k stars 67 forks source link

👷 build: create codeql.yml #248

Closed NielsPraet closed 1 year ago

NielsPraet commented 1 year ago

Adds github code scanning to the repository.

jonasvdd commented 1 year ago

@NielsPraet good work!

Maybe you can also add the CI filter that the unit tests only runs when there are new changes are made to the:

@jvdd - please correct me when I'm missing something!

github-advanced-security[bot] commented 1 year ago

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

jonasvdd commented 1 year ago

resolves #157

jvdd commented 1 year ago

Perhaps also poetry.toml and the Makefile @jonasvdd?

jonasvdd commented 1 year ago

@jvdd, why the poetry.toml and the makefile?

The poetry.lock should be directly affected by the pyproject.toml right? When looking at the test.yml It appears that the makefile is not utilized by the tesing?

jvdd commented 1 year ago

Skip the Makefile - the poetry.toml might however be conflicting with the poetry.lock (when not used correctly).

jonasvdd commented 1 year ago

nice! :)

jonasvdd commented 1 year ago

LGTM! :)