search

predict-idlab / plotly-resampler

Visualize large time series data with plotly.py
https://predict-idlab.github.io/plotly-resampler/latest
MIT License
1.02k stars 66 forks source link

:mag: adding init kwargs to show dash - fix for #265 #269

Closed jonasvdd closed 10 months ago

jonasvdd commented 11 months ago

Fixes #265,

This PR largely alleviates the unclarity of the show_dash_kwargs by removing these from the FigureResampler its constructor and replacing these by the kwargs of the show_dash method.

This show_dash method now also contains init_dash_kwargs which should aid in specifying Dash constructor arguments, which can be of value for kubernetes (k8s) jupyterhub notebook instances.

codecov-commenter commented 10 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (741da5d) 96.46% compared to head (19ca5b8) 96.46%.

Files Patch % Lines
...tly_resampler/figure_resampler/figure_resampler.py 60.00% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #269 +/- ## ======================================= Coverage 96.46% 96.46% ======================================= Files 14 14 Lines 1130 1130 ======================================= Hits 1090 1090 Misses 40 40 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jonasvdd commented 10 months ago

Will review it tonight

jvdd commented 10 months ago

The show_dash_kwargs are already tested for register_plotly_resampler!

https://github.com/predict-idlab/plotly-resampler/blob/741da5d2358bee59c59d1591b0722ab0ea66bbb6/tests/test_registering.py#L132