search

predict-idlab / plotly-resampler

Visualize large time series data with plotly.py
https://predict-idlab.github.io/plotly-resampler/latest
MIT License
990 stars 67 forks source link

:fire: delegate nan behavior to aggregators #294

Closed jonasvdd closed 4 months ago

jonasvdd commented 5 months ago

Removed the check_nans argument of the FigureResampler constructor and its add_traces method. This argument was used to check for NaNs in the input data, but this is now handled by the nan_policy argument of specific aggregators (see for instance the constructor of the MinMax and MinMaxLTTB aggregator).

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3ad7dea) 96.42% compared to head (9fabda1) 96.49%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #294 +/- ## ========================================== + Coverage 96.42% 96.49% +0.07% ========================================== Files 14 14 Lines 1146 1141 -5 ========================================== - Hits 1105 1101 -4 + Misses 41 40 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jonasvdd commented 5 months ago

Ready for review @jvdd!

jonasvdd commented 4 months ago

I added the issue, so this can be merged @jvdd?