Current LTTB (lttbc) algorithm is sometimes numerically unstable

predict-idlab / plotly-resampler

Visualize large time series data with plotly.py

https://predict-idlab.github.io/plotly-resampler/latest

MIT License

1.03k stars 68 forks source link

Current LTTB (lttbc) algorithm is sometimes numerically unstable #93

Closed jvdd closed 2 years ago

jvdd commented 2 years ago

There appears to be (very minor) changes in floating point numbers when using the lttbc LTTB implementation

This causes test test_fwr_time_based_data_s to fail sometimes

A fix for this would be using our own lttb algorithm (also implemented in C) -> see #84

As for now, we will disable this test (as this only occurs in very niche use-cases) and leave this issue open until this problem is resolved (by merging #84)

jonasvdd commented 2 years ago

shoulde be resolved by merging #103

jonasvdd commented 2 years ago

Will be fixed in a new release with #103