search

primefaces-extensions / faces-intellisense

Visual Studio Code extension that provides components completion in the HTML, XHTML and Faces. Based on the official Tag Library definitions.
https://marketplace.visualstudio.com/items?itemName=FlipWarthog.faces-intellisense
MIT License
5 stars 1 forks source link

allow interpolation in style attribute of primeface component #38

Closed DebasishWe closed 1 month ago

DebasishWe commented 1 month ago

while using jsf assignment inside other attributes, no validation check done and no error is shown but while using jsf assigment from bean on style attribute error displays. this error should not be displayed. it is intended behaviour

melloware commented 1 month ago

@DebasishWe can you show screenshots of what you mean? I am having a little trouble understanding the issue?

DebasishWe commented 1 month ago

Screenshot from 2024-09-25 17-48-35 @melloware in this scrrenshot even if style atttribute is correct, it is shown as error. Can this error be removed for this attribute like other attributes. Same also true for script tag.

melloware commented 1 month ago

Ahhh @FlipWarthog i am not sure if this is a Faces Intellisense issue or the fact VScode is treating XHTML as an HTML dialect and thinks the syntax is incorrect?

FlipWarthog commented 1 month ago

Yeah, I think it's the HTML validator in VSCode. If you open a file, VSCode will display the language activated in the bottom right; for XHTML it picks up as HTML:

image

FlipWarthog commented 1 month ago

More specifically, it's the built in CSS validator that is not aware of JSF syntax. Nothing we can do there.

allcontributors[bot] commented 1 month ago

@melloware

I've put up a pull request to add @userTesting! :tada:

melloware commented 1 month ago

@all-contributors add @DebasishWe for userTesting

allcontributors[bot] commented 1 month ago

@melloware

I've put up a pull request to add @DebasishWe! :tada: