primefaces-extensions / faces-intellisense

Visual Studio Code extension that provides components completion in the HTML, XHTML and Faces. Based on the official Tag Library definitions.
https://marketplace.visualstudio.com/items?itemName=FlipWarthog.faces-intellisense
MIT License
6 stars 1 forks source link

Renaming fork #6

Closed per-steinar closed 10 months ago

per-steinar commented 10 months ago

Before publishing the forked extension the extension should be renamed to reflect it not only supporting prime faces.

melloware commented 10 months ago

oh yeah and it should be called faces-intellisense as its not JSF anymore and its generic.

per-steinar commented 10 months ago

"Intellisense for Jakarta Faces" could be an alternative. We need to ensure that we don't step into any trademark issues. https://jakarta.ee/legal/trademark_guidelines/

melloware commented 10 months ago

I like just Intellisense for Faces it keeps Jakarta out of it?

per-steinar commented 10 months ago

As long as it isn't too vague. I'm not familiar with any similar technologies that uses the term faces to describe it self.

melloware commented 10 months ago

OK I see maybe a better would be "Intellisense for Java Faces" I don't like restricting it to just Jakarta since its really a Java based tech?

per-steinar commented 10 months ago

JSF was a part of Java EE. Java EE was handed over to the Eclipse Foundation and renamed to Jakarta EE, due to trademark issues. The latest release is released under the name Jakarta Faces. I think I would be best to use the current name of the technology, even though it is still referred to by its old name.

However un the end, this is your call as owner of the repository.

melloware commented 10 months ago

Here is what I put in the new package.json

  "name": "faces-intellisense",
  "displayName": "Jakarta Faces Intellisense",
  "description": "Jakarta Faces Intellisense provides components completion in the HTML, XHTML and Jakarta Faces. Based on the official Tag Library definitions.",
per-steinar commented 10 months ago

That's probably the best solution. You don't have to change the name and republish it again if they renames JSF again

melloware commented 9 months ago

@per-steinar it is published to VS Code Extenstions now if you want to give it a try.

https://marketplace.visualstudio.com/items?itemName=FlipWarthog.faces-intellisense