probcomp / GenExperimental.jl

Featherweight embedded probabilistic programming language and compositional inference programming library
MIT License
17 stars 2 forks source link

Goal inference MH demo log-score animation is broken #26

Closed marcoct closed 7 years ago

marcoct commented 7 years ago

The log-score for the current trace that is shown does not seem correct. Needs to be debugged.

marcoct commented 7 years ago

I just removed it for now.

mirisr commented 7 years ago

Do you still want me to check it out?

mirisr commented 7 years ago

It was a javascript error. Replace Javascript function add_score with:

function add_score(svg, trace) { var score = svg.selectAll(".score").data([""]); score.exit().remove(); score.enter().append("text").classed("score", true).merge(score) .attr("x", 50).attr("y", 95) .text(function(d){return trace.log_weight.toFixed(2)}); }

also, slowing the "animation" by adding sleep(0.5)

mirisr commented 7 years ago

Passing to marco to integrate into original notebook

marcoct commented 7 years ago

Integrated.