probcomp / GenExperimental.jl

Featherweight embedded probabilistic programming language and compositional inference programming library
MIT License
17 stars 2 forks source link

Augment goal infernce trace rendering to show waypoint #27

Closed marcoct closed 7 years ago

marcoct commented 7 years ago

For use with agent_waypoint_model.

marcoct commented 7 years ago

This will involve modifying the Javascript trace rendering code to add a new circle for the waypoint if it exists in the given trace. It may not exist. It exists when use-waypoint is true and it does not exist when use-waypoint is false. The rendering should still run but simply not show the waypoint if it does not exist. Make it visually distinct from the other elements of the rendering.

Test by simulating some traces of agent_waypoint_model and rendering them in "tile" form (e.g. using Figure as used elsewhere in the notebook).

mirisr commented 7 years ago

I thought a purple would work... but it's too close to both the start and goal points... we can talk about it later.

screen shot 2017-06-22 at 8 30 43 pm screen shot 2017-06-22 at 8 31 02 pm
mirisr commented 7 years ago

closing for now

mirisr commented 7 years ago

Actually sending this to marco to put into the real notebook.

marcoct commented 7 years ago

Looks great, I'll add it now.

marcoct commented 7 years ago

Integrated in https://github.com/probcomp/gen-examples/commit/c0f423555f241c5d160e2b43ee4caf68f677a104