search

probcomp / GenExperimental.jl

Featherweight embedded probabilistic programming language and compositional inference programming library
MIT License
17 stars 2 forks source link

20170711 iriss modules #52

Closed mirisr closed 6 years ago

mirisr commented 7 years ago

Implemented and tested the multivariate module.

mirisr commented 6 years ago

@marcoct I've updated the requested change, and tested them manually. I added the test, but since I use the same code, it doesn't seem like a good test. Perhaps I should write the multivariate pdf manually in the module?

Also let me know how I can better address each "requested change" on GitHub if you can with commits.

marcoct commented 6 years ago

I agree that the test for the primitives aren't very useful. I think it would be a little better to compute the logpdf for some test vlaues using numpy or scipy, and check that it matches those values.