process-analytics / bpmn-layout-generators

Tools for generating missing BPMNDiagram elements in BPMN files
Apache License 2.0
37 stars 6 forks source link

feat(render): adjust exported gateways and events shape and size #35

Closed tbouffard closed 4 years ago

tbouffard commented 4 years ago

This is an improvement of the initial implementation provided by #25 The dimensions of the gateways and events have been improved (width and height are the same), the label positions have also been adjusted for these BPMN elements

Screenshots with A.2.0.bpmn file from BPMN-MIWG

Notice that comparing to the #25 rendering, the sort algorithm has switched Task 2 and Task 4, so the edge from Task 2 to the end event overlaps the final gateway

svg export It now identifies gateways and events

pr35_commit_f3e2674e_A 2 0__svg_export

bpmn-visualization-js (0.1.3 dev commit 1172325) Label positions from the BPMN file are not used for rendering, the lib currently used arbitrary positions

pr35_commit_f3e2674e_A 2 0__bpmn-visualisation-js@1172325196f19cf601a0d022abe13836ce86a7a0

demo.bpmn.io (bpmn-js@6.5.1) Label positions are taken from the BPMN file

pr35_commit_f3e2674e_A 2 0__bpmn-io-demo@6 5 1

baptistemesta commented 4 years ago

That's beautiful!