search

process-analytics / bpmn-layout-generators

Tools for generating missing BPMNDiagram elements in BPMN files
Apache License 2.0
37 stars 6 forks source link

Paint/render edge arrow in svg export #54

Closed tbouffard closed 2 months ago

tbouffard commented 4 years ago

52 introduced edge display in the svg export, but there is currently no arrow.

We probably will need the edge direction to know how to paint the arrow

tbouffard commented 3 years ago

82 marks the edge target point with a circle. This is a 1st implementation that let identify the direction of the edge.

Rendering arrow is more complex as it requires to know the last segment orientation. This information is currently not available in the code that manage the SVG export. We only have the point coordinates, the orientation computed before is not passed along with the point.

I am not sure we really need the arrow here. The circles provide the main info: the edge direction. So IMHO, circles are enough.

tbouffard commented 2 months ago

Fixed by #129 in https://github.com/process-analytics/bpmn-layout-generators/releases/tag/v0.2.0.