project-everest / everest

https://project-everest.github.io/
Apache License 2.0
193 stars 29 forks source link

Hashes vs submodules #59

Closed wintersteiger closed 6 years ago

wintersteiger commented 6 years ago

Should we consider replacing hashes.sh with git submodules? They have exactly the same purpose as far as I can tell.

@protz @gugavaro @tahina-pro @BarryBo

msprotz commented 6 years ago

They used to be submodules but then we backtracked and went into the hashes.sh solution

The reasons weren't documented but as far as I remember:

the latter is what matter for the everest upgrade, with submodules, we wouldn't have the ability to do that; also, hashes.sh enables a variety of checks (make sure you've pushed your commits, that your branch is in sync) which I believe would be harder to achieve with just submodules

wintersteiger commented 6 years ago

Thanks for explaining, makes sense!

(The no-branches restriction doesn't apply to recent gits anymore.)