project-everest / everest

https://project-everest.github.io/
Apache License 2.0
193 stars 29 forks source link

forall: continue on errors #70

Closed mtzguido closed 4 years ago

mtzguido commented 4 years ago

Mostly motivated by ./everest forall git grep blah. If one of the greps comes out empty, it also has a non-zero exit code and the script will not run the command on the remaining repos (since we have -e). The same happens when git invokes a pager (less) and one presses 'q' to quit.

While at it use a subshell instead of cd-ing back to the parent directory.

msprotz commented 4 years ago

I would replace true by echo return code was $? (possibly in color) to let the user know something might have gone wrong

other than that looks good to me

mtzguido commented 4 years ago

Ah yes, good idea. Done now.