Remove SCons logic - Githubissues

project-everest / everest

https://project-everest.github.io/

Apache License 2.0

193 stars 29 forks source link

Remove SCons logic #89

Closed msprotz closed 2 years ago

msprotz commented 2 years ago

As far as I know, we no longer need SCons to build Everest. As such, I would like to remove all of the checks and logic in the everest script.

This will relax a lot of the python checks we currently have in place
This will make installation easier on fresh systems: our dockerfiles have to use a custom ppa for python 3.6, and the hardlink from /usr/bin/python3 to python3.6 is likely going to cause issues as time goes by and python3.6 becomes more and more outdated

Tahina and Chris, can you tell me what you think? Thanks!

msprotz commented 2 years ago

I think Tahina relaxed the 3.6 exact version requirement a little while ago. But it's causing more problems, as the version of scons we advocate does not work with recent pythons (3.10 errors out with something related to Iterable).

Whoever needs SCons is probably better off handling it themselves rather than by complying with the slightly outdated versions we recommend (SCons is now in its 4.x release series).

The build failed because of the wasm transition. @tahina-pro let us know once wasm is back on track and I'm happy to re-run CI for this!

tahina-pro commented 2 years ago

In fact, Everest CI and Everest upgrades, at least on Linux, showed that:

F# is not used -- or, more precisely, ./everest make , ./everest test and Everest upgrades succeed even if no fsharp command is available through the PATH
python pointing to Python 3 is harmless

So, I am going to suggest more simplifications here (once I merge the migration to wasm-2.0.0) Stay tuned!