project8 / dripline

Slow controls for medium scale physics experiments based on AMQP centralized messaging
http://www.project8.org/dripline
1 stars 0 forks source link

reply message should not be the entire payload #118

Closed laroque closed 9 years ago

laroque commented 9 years ago

There may be times when a return code indicates a warning and so a return-msg is warranted, but a valid result is also present. As such, a 'return-msg' field should be used. This being the case, all exceptions/errors should put their message into that field for consistency. We'll need to update the wire protocol to reflect these. I should also abstract away the payload formatting to reflect our standards (and this too should be explicit in the wire protocol).

laroque commented 9 years ago

Okay, wire-protocol decision made, it is going to be its own field. There isn't an obvious way to name it in a consistent way. retmsg is probably closest but I think I prefer something more spelled out

laroque commented 9 years ago

return-msg

nsoblath commented 9 years ago

After slightly more discussion on Slack, return_msg to be more consistent with other uses of the underscore.

laroque commented 9 years ago

Okay, in the case of a reply message, if the payload is not a dict, the value is dumped into payload.values[]