projectatomic / ContainerApplicationGenericLabels

Default Containerized Application Labels used to document the application and/or image
68 stars 29 forks source link

Image name that includes string '--' not acceptable in docker 1.8+ #51

Open aweiteka opened 8 years ago

aweiteka commented 8 years ago

Per vendor/redhat/names.md we accept '--' in the build image name. This causes a failure in docker v1.8+.

$ rpm -q docker
docker-1.8.1-3.git32b8b25.fc22.x86_64
$ cat /etc/redhat-release 
Fedora release 22 (Twenty Two)
$ sudo docker build -t test/atomicapp--name .
repository name component must match "[a-z0-9]+(?:[._-][a-z0-9]+)*"
$ sudo docker build -t test/atomicapp-name .
Sending build context to Docker daemon  2.08 MB
Step 0 : FROM centos:centos7
...
thomasmckay commented 8 years ago

To reproduce, attempt to create a new repository on hub.docker.com named "some--thing".

thomasmckay commented 8 years ago

https://forums.docker.com/t/docker-hub-repository-name-does-not-except-two-dashes/3434

rhatdan commented 8 years ago

Looks like just a bug in the regex that checks.

Changing
[a-z0-9]+(?:[._-][a-z0-9]+)*
to
[a-z0-9]+(?:[._-]+[a-z0-9]+)*

Might fix the problem. Unless docker really wants to force it to be just a single separator field.