search

projectatomic / ContainerApplicationGenericLabels

Default Containerized Application Labels used to document the application and/or image
68 stars 29 forks source link

add openshift labels for app deployment #69

Open aweiteka opened 8 years ago

aweiteka commented 8 years ago

cc @bparees @brianwcook

aweiteka commented 8 years ago

@bparees I didn't see docs on mid hooks. Do I have the right hook type in mind?

bparees commented 8 years ago

@aweiteka might be missing doc. @ironcladlou do we not have doc for mid-hooks?

bparees commented 8 years ago

we probably need to see an example of how those labels will actually look with values. Presumably it's going to be a giant blob of json (that defines a hook), which seems unfriendly but is going to be the most flexible option....

ironcladlou commented 8 years ago

There's a documentation gap around mid hooks. They're supported only by the Recreate strategy. The docs for mid will should look the same as for pre and post: https://docs.openshift.org/latest/dev_guide/deployments.html#recreate-strategy

aweiteka commented 8 years ago

Mid hooks docs issue pointing to implementation PR: https://github.com/openshift/openshift-docs/issues/1779

aweiteka commented 8 years ago

We could add cmd and args labels but relying on the Dockerfile for those is probably less confusing.

aweiteka commented 8 years ago

@brianwcook updated.