Open aweiteka opened 8 years ago
@bparees I didn't see docs on mid hooks. Do I have the right hook type in mind?
@aweiteka might be missing doc. @ironcladlou do we not have doc for mid-hooks?
we probably need to see an example of how those labels will actually look with values. Presumably it's going to be a giant blob of json (that defines a hook), which seems unfriendly but is going to be the most flexible option....
There's a documentation gap around mid hooks. They're supported only by the Recreate
strategy. The docs for mid
will should look the same as for pre
and post
: https://docs.openshift.org/latest/dev_guide/deployments.html#recreate-strategy
Mid hooks docs issue pointing to implementation PR: https://github.com/openshift/openshift-docs/issues/1779
We could add cmd
and args
labels but relying on the Dockerfile for those is probably less confusing.
@brianwcook updated.
cc @bparees @brianwcook