search

projectatomic / ContainerApplicationGenericLabels

Default Containerized Application Labels used to document the application and/or image
68 stars 29 forks source link

Allow optional dash between PRODUCT and $PRODUCTGEN #86

Closed pbabinca closed 6 years ago

pbabinca commented 6 years ago

This formalizes the naming policy that can be seen in the wild already.

pbabinca commented 6 years ago

//cc @ssampat

ssampat commented 6 years ago

Thanks, Pavol! You probably missed out this one - https://github.com/projectatomic/ContainerApplicationGenericLabels/pull/86/commits/f8e36b9c3735c745bb4a5fae4e1819ff52e50222#diff-91ad106c9870dba967a0828e35335257R211 ?

pbabinca commented 6 years ago

Thanks, fixed: https://github.com/projectatomic/ContainerApplicationGenericLabels/pull/86/files#diff-91ad106c9870dba967a0828e35335257R75

ssampat commented 6 years ago

Thanks!

pbabinca commented 6 years ago

@ssampat who can review and merge this?

ssampat commented 6 years ago

@aweiteka @julienlim @rhatdan can you take a look?

rhatdan commented 6 years ago

LGTM