search

projectriff / riff

riff is for functions
https://projectriff.io
Apache License 2.0
799 stars 64 forks source link

Test upgrades from last riff release #1351

Closed scothis closed 3 years ago

scothis commented 5 years ago

Helm has the ability to upgrade chart installs in a cluster. We can use FATS to install riff 0.4.0, create a couple resources, upgrade the cluster to the current build and then test that those resources still work.

trisberg commented 5 years ago

Looks like helm upgrade doesn't install the CRDs that are missing from an 0.4.0 install so it fails:

$ helm upgrade riff projectriff/riff --version 0.5.0-snapshot --set tags.core-runtime=true --set tags.knative-runtime=true
UPGRADE FAILED
Error: [unable to recognize "": no matches for kind "Certificate" in version "certmanager.k8s.io/v1alpha1", unable to recognize "": no matches for kind "ClusterBuilder" in version "build.pivotal.io/v1alpha1", unable to recognize "": no matches for kind "Issuer" in version "certmanager.k8s.io/v1alpha1"]
Error: UPGRADE FAILED: [unable to recognize "": no matches for kind "Certificate" in version "certmanager.k8s.io/v1alpha1", unable to recognize "": no matches for kind "ClusterBuilder" in version "build.pivotal.io/v1alpha1", unable to recognize "": no matches for kind "Issuer" in version "certmanager.k8s.io/v1alpha1"]

I guess we could install all the CRDs before upgrading, not sure this is worth it though.

scothis commented 5 years ago

Removing from v0.5.0, since upgrades from 0.4.0 via helm will not be practical.