search

projectriff / riff

riff is for functions
https://projectriff.io
Apache License 2.0
798 stars 64 forks source link

[DRAFT] RFC 0014: Binding Injection #1382

Closed scothis closed 4 years ago

scothis commented 4 years ago

readable

This is an early draft open for feedback, but not ratification.

dsyer commented 4 years ago

This looks like a good starting point. Using CNB bindings seems like a good idea, but it still forces the app to know about that in some detail. I would like to be able to inject other things to adapt apps from a specific stack to the CNB layout. An init container, and an environment variable are the two examples that come to mind that I have needed to adapt Spring Boot apps to CNB bindings.

I added some comments inline as well.

scothis commented 4 years ago

I would like to be able to inject other things to adapt apps from a specific stack to the CNB layout. An init container, and an environment variable are the two examples that come to mind that I have needed to adapt Spring Boot apps to CNB bindings.

@dsyer injecting other elements is out of scope for this RFC, but is something that should be relatively easy to do by creating other Knative Bindings with a PodSpecable subject.

scothis commented 4 years ago

Closing, as CNB Binding is deprecated in favor of Service Bindings. Will open a new RFC

scothis commented 4 years ago

Updated at #1390